Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renew external certificates via the added multi-tenancy support #1973

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Renew external certificates via the added multi-tenancy support #1973

merged 1 commit into from
Feb 7, 2024

Conversation

cniackz
Copy link
Contributor

@cniackz cniackz commented Feb 6, 2024 •
edited

Objective:

To renew external certificates after their expiration.

Continuation:

Logs:

I0207 20:38:35.018698       1 operator.go:184] External secret found: operator-ca-tls-1
I0207 20:38:35.194748       1 operator.go:188] Appending cert from operator-ca-tls-1 secret
I0207 20:38:35.206609       1 tenants.go:118] external certificate successfully renewed for the tenant

Renewed cert example:

$ k get secret operator-ca-tls-1  -n minio-operator
NAME                TYPE     DATA   AGE
operator-ca-tls-1   Opaque   1      69s

@cniackz cniackz self-assigned this Feb 6, 2024
@cniackz cniackz changed the title [WIP] - Renew external certs Renew external certificates via the added multi-tenancy support Feb 6, 2024
@cniackz cniackz added the enhancement New feature or request label Feb 6, 2024
pjuarezd
pjuarezd previously approved these changes Feb 6, 2024
View reviewed changes
cesnietor
cesnietor previously requested changes Feb 6, 2024
View reviewed changes
pkg/controller/monitoring.go Outdated Show resolved Hide resolved
pkg/controller/monitoring.go Outdated Show resolved Hide resolved
pkg/controller/monitoring.go Outdated Show resolved Hide resolved
pkg/controller/monitoring.go Outdated Show resolved Hide resolved
pkg/controller/monitoring.go Outdated Show resolved Hide resolved
pkg/controller/monitoring.go Outdated Show resolved Hide resolved
pkg/controller/monitoring.go Outdated Show resolved Hide resolved
pkg/controller/monitoring.go Outdated Show resolved Hide resolved
pkg/controller/monitoring.go Outdated Show resolved Hide resolved
pkg/controller/monitoring.go Outdated Show resolved Hide resolved
jiuker
jiuker previously approved these changes Feb 7, 2024
View reviewed changes
@cniackz cniackz dismissed stale reviews from jiuker and pjuarezd via 18f674e February 7, 2024 17:15
@cniackz cniackz dismissed cesnietor’s stale review February 7, 2024 17:18

The changes have been made.

cesnietor
cesnietor approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjuarezd pjuarezd merged commit 66cb587 into minio:master Feb 7, 2024
26 checks passed
@cniackz cniackz deleted the renew-external-certs branch February 8, 2024 12:41
@cniackz
Copy link
Contributor Author

cniackz commented Feb 8, 2024

Thank you guys ❤️

@cniackz cniackz mentioned this pull request Mar 25, 2024
Open
@cniackz cniackz mentioned this pull request Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjuarezd pjuarezd pjuarezd approved these changes

@cesnietor cesnietor cesnietor approved these changes

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@jiuker jiuker Awaiting requested review from jiuker

Assignees

@cniackz cniackz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cniackz @pjuarezd @cesnietor @jiuker