Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Krew plugin #2051

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

dvaldivia
Copy link
Collaborator

We are deprecating the krew plugin in favor of focusing on the kustomize and helm approach of installing the operator.

@shtripat
Copy link
Contributor

There is an enterprise test using this for expand tenant feature test. We may need to change that.

cniackz
cniackz previously approved these changes Mar 28, 2024
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cniackz
Copy link
Contributor

cniackz commented Mar 28, 2024

Tested and deployed the tenant with this compiled version. It shouldn't break functionality, although I agree with @shtripat that tests should catch up with the changes, as should the documentation. @ravindk89, please be aware.

Screenshot 2024-03-28 at 8 32 47 AM

@cniackz
Copy link
Contributor

cniackz commented Mar 28, 2024

Oh I see, tests are updated and regarding common.sh these changes looks good to me:

Screenshot 2024-03-28 at 8 37 31 AM

Copy link
Contributor

@allanrogerr allanrogerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvaldivia @cniackz
This is a breaking change to our users' workflows. Therefore how will this be announced, giving users sufficient time to change their workflows?

@ravindk89
Copy link
Contributor

@dvaldivia @cniackz if I may suggest:

  • Hold this PR for now
  • Open a fresh PR that marks all kubectl minio commands as deprecated and returns a non-blocking warning on each run (this may break user workflows who parse output in some way)
  • Docs will warn that we are deprecating kubectl minio route of installation and focus on kubectl apply -k github.com/minio/operator and the equivalent for Tenants
  • Merge this PR for the subsequent Operator release

With this, we would

  • Publish 5.0.15 with a deprecation warning
  • Publish 5.0.16 with the deprecation

Users do not always track latest stable that closely, and can stay on 5.0.15 until they have readied their systems to move to Kustomize.

Thoughts?

Makefile Show resolved Hide resolved
harshavardhana
harshavardhana previously approved these changes Mar 29, 2024
@harshavardhana
Copy link
Member

This is a breaking change to our users' workflows. Therefore how will this be announced, giving users sufficient time to change their workflows?

There is no such workflow

@harshavardhana
Copy link
Member

@dvaldivia @cniackz if I may suggest:

  • Hold this PR for now
  • Open a fresh PR that marks all kubectl minio commands as deprecated and returns a non-blocking warning on each run (this may break user workflows who parse output in some way)
  • Docs will warn that we are deprecating kubectl minio route of installation and focus on kubectl apply -k github.com/minio/operator and the equivalent for Tenants
  • Merge this PR for the subsequent Operator release

With this, we would

  • Publish 5.0.15 with a deprecation warning
  • Publish 5.0.16 with the deprecation

Users do not always track latest stable that closely, and can stay on 5.0.15 until they have readied their systems to move to Kustomize.

Thoughts?

No we move to v6.0.0 - we break this and bump the major version.

@feorlen
Copy link
Contributor

feorlen commented Mar 29, 2024

What is the timeline for this? It's a major change to how docs describes the k8s install process. We do have some preliminary docs for kustomize in GitHub, but multiple pages in the web docs need rework to feature that instead of krew.

@allanrogerr allanrogerr mentioned this pull request Apr 5, 2024
Copy link
Contributor

@allanrogerr allanrogerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the changes to goreleaser made here: #2062

@cniackz
Copy link
Contributor

cniackz commented Apr 17, 2024

I will solve the conflict:

Screenshot 2024-04-17 at 5 32 10 PM

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@cniackz cniackz dismissed stale reviews from harshavardhana and themself via ceff120 April 17, 2024 21:34
@cniackz cniackz self-requested a review April 17, 2024 21:35
@cniackz cniackz dismissed allanrogerr’s stale review April 17, 2024 21:36

The change that was taken into consideration is now gone!

@cniackz
Copy link
Contributor

cniackz commented Apr 17, 2024

The conflict has been resolved, and now I'm awaiting the completion of tests. Once they pass, I'll request the team to review again, and then proceed with the merge.

@harshavardhana harshavardhana merged commit 6a3d80e into minio:master Apr 17, 2024
26 checks passed
This was referenced Apr 18, 2024
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request May 9, 2024
https://build.opensuse.org/request/show/1172784
by user ojkastl_buildservice + dimstar_suse
kubectl-minio was deprecated upstream, see minio/operator#2051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants