Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display UI binary error messages instead of silently exiting #2055

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

kaankabalak
Copy link
Contributor

In the same vein as minio/console#3276, we would like to record the error when an error prevents ./minio-operator ui from running.

Fixes #1755

@kaankabalak
Copy link
Contributor Author

Not sure why the decommission test timed out, I don't think it's related to the changes in the PR. If so, please do let me know 👍

@kaankabalak
Copy link
Contributor Author

kaankabalak commented Apr 9, 2024

Not sure why the decommission test timed out, I don't think it's related to the changes in the PR. If so, please do let me know 👍

Seems like it's failing with the following error message this time around. I am merging the PR as this looks unrelated with the change.

------
 > [stage-1 5/5] COPY minio-operator /minio-operator:
------
Dockerfile:25
--------------------
  23 |     COPY LICENSE /licenses/LICENSE
  24 |     
  25 | >>> COPY minio-operator /minio-operator
  26 |     
  27 |     ENTRYPOINT ["/minio-operator"]
--------------------
ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref 154f1920-6824-4aef-9297-2479406a90ff::lth5s48sbb66gtsen54z4gjd0: "/minio-operator": not found
/home/runner/work/operator/operator/testing/decommission-test.sh: cannot docker build -t minio/operator:noop .

@kaankabalak kaankabalak merged commit 6f99550 into minio:master Apr 16, 2024
26 checks passed
@kaankabalak kaankabalak deleted the log-api-error branch April 16, 2024 16:20
@cesnietor
Copy link
Contributor

thanks @kaankabalak !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

./minio-operator ui command exits without any message if port is occupied
4 participants