To fix goreleaser #2062
Merged
To fix goreleaser #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
force-pushed
the
fix-goreleaser-apr5
branch
2 times, most recently
from
0af9753
to
9be330e
Compare
cniackz
force-pushed
the
fix-goreleaser-apr5
branch
from
9be330e
to
cbb4e75
Compare
allanrogerr
previously requested changes
Apr 5, 2024
There was a problem hiding this comment.
This seems to be accomplishing what #2051 is already doing.
Could you check with @dvaldivia to add you goreleaser change?
|
@allanrogerr, this is unrelated to the 2051 PR. This PR is simply to fix the test, not to deprecate anything. Initially, I thought the plugin was deprecated, but now I see that the PR is still open. We still need this change to fix our CI/CD pipeline. Please review it again. |
|
Thank you anyway for the review @allanrogerr because it made me realize we never deprecated the plugin 👍 |
allanrogerr
approved these changes
Apr 6, 2024
harshavardhana
approved these changes
Apr 6, 2024
|
Thank you guys ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
To fix
goreleasertest, that's it!Additionally use proper flag:
Other files:
Since plugin is not deprecated, these files got updated as well:
kubectl-minio/go.modkubectl-minio/go.sum