Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: readonly console #2066

Merged
merged 1 commit into from
Apr 18, 2024
Merged

feat: readonly console #2066

merged 1 commit into from
Apr 18, 2024

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Apr 9, 2024

Fixes #1905

Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cniackz
Copy link
Contributor

cniackz commented Apr 16, 2024

I've reviewed this PR, and I find it wonderful how you can manipulate RBAC permissions to grant read-mode access by incorporating fields into the helm chart. I really appreciate this concept and will wait for the tests to pass before approving this PR.

Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cniackz
Copy link
Contributor

cniackz commented Apr 16, 2024

I will await the team's review of this PR, after which we can proceed with the merge.

@pjuarezd pjuarezd merged commit c07c650 into minio:master Apr 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator Console in Read-Only mode
4 participants