Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an error type representing decryption failure #25

Merged
merged 1 commit into from Mar 27, 2018
Merged

Conversation

aead
Copy link
Member

@aead aead commented Mar 14, 2018

This commit adds an error type: sio.Error. It is returned
by an io.Reader / io.Writer if the decryption failed. A type check
can be used to distingush a decryption error from other reading/writing
errors like network errors, short buffer errors, ...

Fixes #24

Copy link
Member

@donatello donatello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - however it conflicts with master.

@aead aead force-pushed the error branch 2 times, most recently from ab0bc66 to 2fbfbf6 Compare March 27, 2018 10:35
This commit adds an error type: sio.Error. It is returned
by an io.Reader / io.Writer if the decryption failed. A type check
can be used to distingush a decryption error from other reading/writing
errors like network errors, short buffer errors, ...

Fixes #24
@aead aead merged commit 6a41828 into minio:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants