Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't touch HTTP headers where possible #616

Open
nate-at-gusto opened this issue Jun 6, 2024 · 1 comment
Open

Don't touch HTTP headers where possible #616

nate-at-gusto opened this issue Jun 6, 2024 · 1 comment

Comments

@nate-at-gusto
Copy link
Contributor

Even if disable_caching is on, we still overwrite the applications HTTP cache headers.

This can make HTTP caching difficult to observe in development mode. I understand why we have hacks and workarounds here, but it would be better if we could avoid touching this stuff and let the app do it's thing.

@suryanarayanan035
Copy link

Hello @nate-at-gusto , we are modifying the HTTP header to prevent browser from storing cache only if disable_caching is on. So, I don't find any problems with adding no-store to HTTP header if disable caching is on and feel like its the right thing to do.

If you still find that we need to prevent modifying HTTP headers, then can you please explain me the problem we will be facing here if we just let it be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants