Issue #51 Add GitLab CI runner #52
Conversation
gbraad
force-pushed
the
gitlab
branch
2 times, most recently
from
1a86a39
to
6690128
Compare
.gitlab-ci.yml
Outdated
| - cd iso | ||
| - echo \"$(cat os-release.template)\" > os-release | ||
| - REMOVE_CONTAINER_IMAGES=y ./build.sh | ||
| - cd .. |
There was a problem hiding this comment.
So no tests execution here right?
|
Currently a restriction as for shared/public runners we rely on
docker-in-docker to build the images. This happens due a very minimal image
docker:dind. It also does not provide make. Working on improving this...
This was a first attempt.
…--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]
|
👍 Got you. |
|
Using Docker-in-Docker using a Fedora 26 image. Which allows me to run our regular build process using |
gbraad
changed the title
|
Note: intermediate docker images are removed when |
|
So this is a WIP? |
|
WIP status was removed 15 hours ago ;-) |
|
What's the empty "iso/.gitlab-ci.yml" for? |
|
|
||
| # Get nsenter. | ||
| docker run --rm jpetazzo/nsenter cat /nsenter > $tmpdir/nsenter && chmod +x $tmpdir/nsenter | ||
|
|
||
| # Get socat | ||
| docker build -t socat -f Dockerfile.socat . | ||
| docker run socat cat socat > $tmpdir/socat | ||
| docker run $DOCKER_RUN_OPTIONS socat cat socat > $tmpdir/socat |
There was a problem hiding this comment.
Where does $DOCKER_RUN_OPTIONS come into play?
There was a problem hiding this comment.
when REMOVE_CONTAINER_IMAGES is set, it gets a value of --rm. This is needed as GitLab shared CI runners have a limited amount of disk space assigned to a build, and without removing intermediate images and containers, we exhaust that before the build of boot2docker even started.
|
Any feedback? @praveenkumar @LalatenduMohanty @budhrg ? |
|
Looks good to me @gbraad |
| echo "Building in $tmpdir." | ||
| cp -r . $tmpdir/ | ||
|
|
||
| pushd $tmpdir |
There was a problem hiding this comment.
Is there any specific reason why we are removing pushd/pop? Is it because of sh instead bash?
There was a problem hiding this comment.
yes. it can be restored as we are not using the docker;git image anymore anyways.
what was the motivation/pro to use popd/pushd?
|
|
||
| # Do the build. | ||
| docker build -t iso . | ||
| docker build -t b2diso . |
Fixes #51
Add GitLab CI runner definition
Note: some changes are needed to allow shared runners