Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cri-o as a container-runtime #1442

Open
vbatts opened this issue Sep 22, 2017 · 23 comments
Open

support cri-o as a container-runtime #1442

vbatts opened this issue Sep 22, 2017 · 23 comments

Comments

@vbatts
Copy link

vbatts commented Sep 22, 2017

https://github.com/kubernetes-incubator/cri-o is runs under openshift 3.6 and newer, quite nicely.

This is now an open PR with minikube, and would be great to have this in minishift as well.
kubernetes/minikube#1998

@LalatenduMohanty
Copy link
Member

@vbatts Thanks. We will take a look and get back to you.

@vbatts
Copy link
Author

vbatts commented Sep 22, 2017

👍

@gbraad
Copy link
Member

gbraad commented Sep 23, 2017

I noticed you proposed cri-o as a runtime for minikube. We are in the process of supporting this image, too. See #1058

@gbraad
Copy link
Member

gbraad commented Sep 23, 2017

@vbatts are packages ready for CentOS to support this?

@praveenkumar
Copy link
Contributor

http://cbs.centos.org/koji/packageinfo?packageID=5695 looks like cri-o package is build on cbs also but not sure how mature this is and how to consume when we build our own ISO. Might be we will keep this as experiment feature for minishift till it part of offical repos?

@gbraad
Copy link
Member

gbraad commented Sep 25, 2017

adding runtime selections from minishift as experimental feature is not difficult, but experimental features for the ISO is slightly more difficult to handle. We will have to think how to handle this.

@gbraad
Copy link
Member

gbraad commented Sep 25, 2017

One of the things we haven't handled yet is the version number problem related to the ISO we use. For minikube it is easier to handle, as this is part of the release. In our case I want to do feature detection for the ISO we use... and based on that allow certain features to happen... like mounting CIFS, etc.

However, a runtime selection happens during the provisioning, so the request might only fail after the VM started, and the provisioning just started...

How do you see this, @praveenkumar ?

@LalatenduMohanty LalatenduMohanty self-assigned this Sep 27, 2017
@stale
Copy link

stale bot commented Nov 26, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale label Nov 26, 2017
@gbraad
Copy link
Member

gbraad commented Nov 26, 2017

Still of interest to us, although we can also use the Minikube ISO now.

@stale stale bot removed the status/stale label Nov 26, 2017
@gbraad
Copy link
Member

gbraad commented Nov 26, 2017

@vbatts I know for Fedora this is easy to do... but what needs to be provided on CentOS to make this work?

@stale
Copy link

stale bot commented Jan 25, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale label Jan 25, 2018
@stale stale bot closed this as completed Feb 8, 2018
@coolbrg coolbrg reopened this Feb 8, 2018
@stale stale bot removed the status/stale label Feb 8, 2018
@vbatts
Copy link
Author

vbatts commented Nov 7, 2018

bump

@gbraad I missed your question. My apologies. I thought there were centos7 packages! :-\ perhaps since there are RHEL builds of it then it can't be in EPEL now? I'm confused. @lsm5 do you know where/how to get cri-o packages to centos7?

@gbraad
Copy link
Member

gbraad commented Nov 7, 2018

We have since made a Fedora ISO: https://github.com/minishift/minishift-fedora-iso
In this ISO we can easily add crio, podman, etc: minishift/minishift-fedora-iso#14

@lsm5
Copy link

lsm5 commented Nov 7, 2018 via email

@gbraad
Copy link
Member

gbraad commented Nov 7, 2018

we do have a PR for the Fedora ISO: minishift/minishift-fedora-iso#14

@lsm5
Copy link

lsm5 commented Nov 7, 2018 via email

@gbraad
Copy link
Member

gbraad commented Nov 7, 2018

RE: fedora, cri-o is now being supported as a module and not as a vanilla rpm.

@praveenkumar ^^

@fkluknav
Copy link

fkluknav commented Nov 7, 2018

Centos 7 contains cri-o-3.10, available at http://mirror.centos.org/centos/7/paas/x86_64/openshift-origin310/
Repo file for yum with a link pointing there is in centos-release-openshift-origin310.rpm, available from centos extras.
Cri-o-3.11 should be available soon, together with openshift 3.11. In the meantime, it is in https://buildlogs.centos.org/centos/7/paas/x86_64/openshift-origin311/
Podman should be similarly available soon. In the meantime, https://buildlogs.centos.org/centos/7/virt/x86_64/container/
@gbraad, does it andswer your question?

@fkluknav
Copy link

fkluknav commented Nov 7, 2018

@praveenkumar, about maturity, it should be a rebuild of what Red Hat ships, for good or ill.

@praveenkumar
Copy link
Contributor

@vbatts We do have a PR for centos side about same but as part of minishift we uses oc cluster up which doesn't support a different container runtime than docker. Moving forward with OpenShift 4.0 side oc cluster up no longer exist, which means we need a different way to bring up a single node cluster. I am not sure what benefit a minishift user get just including it as a package and not able to consume it due to cluster up limitation.

@gbraad
Copy link
Member

gbraad commented Nov 22, 2018 via email

@thomasmckay
Copy link
Contributor

Is this a "thing" in minishift? Are there instructions somewhere?

@gbraad
Copy link
Member

gbraad commented Jan 25, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants