Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log is not closed properly in the integration tests #2365

Closed
agajdosi opened this issue May 7, 2018 · 1 comment
Closed

Log is not closed properly in the integration tests #2365

agajdosi opened this issue May 7, 2018 · 1 comment
Assignees
@agajdosi
Labels
component/integration-test kind/bug priority/minor resolution/done
Milestone
v1.17.0

Comments

@agajdosi
Copy link

agajdosi commented May 7, 2018

Log of integration tests has problems with closing because of the logFile is initiated wrongly:

logFile, err := func()

The code above initiates local copy of logFile and did not used logFile declared at top of the package. As result when the itests later tries to close the log it ends with an error.
@agajdosi agajdosi added this to the v1.18.0 milestone May 7, 2018
@agajdosi agajdosi self-assigned this May 7, 2018
agajdosi pushed a commit to agajdosi/minishift that referenced this issue May 7, 2018
Issue minishift#2365 Log is not closed properly in the integration tests
95079fd
LalatenduMohanty pushed a commit that referenced this issue May 7, 2018
@LalatenduMohanty
Issue #2365 Log is not closed properly in the integration tests
ec15fed
@LalatenduMohanty
Copy link
Member

Resolved via #2366

@LalatenduMohanty LalatenduMohanty modified the milestones: v1.18.0, v1.17.0 May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agajdosi agajdosi

Labels
component/integration-test kind/bug priority/minor resolution/done
Projects
None yet
Milestone
v1.17.0
Development

No branches or pull requests
2 participants
@LalatenduMohanty @agajdosi