Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for github.com/machine-drivers/docker-machine-driver-vmware #2383

Open
LalatenduMohanty opened this issue May 14, 2018 · 7 comments

Comments

@LalatenduMohanty
Copy link
Member

We should add support for https://github.com/machine-drivers/docker-machine-driver-vmware in Minishift. We already have the code for VMWare, so we need to check if it needs to change or update for this.

@praveenkumar
Copy link
Contributor

@LalatenduMohanty Problem is do we have the hardware to test those bits because it will go back to our CDK also?

@LalatenduMohanty
Copy link
Member Author

@praveenkumar At this point I am only thinking about upstream Minishift project. Now that the driver plugin is for both VMWare workstation and Fusion, we can just test VMWare workstation and it can be installed on Linux and Windows. So yes we have the hardware.

@anjannath
Copy link
Member

@LalatenduMohanty I'd like to work on this for the next sprint.

@gbraad
Copy link
Member

gbraad commented May 21, 2018 via email

@anjannath
Copy link
Member

@gbraad Will do, but am planning try out first if i am able to use that driver binary to start a vm by using docker-machine

@LalatenduMohanty LalatenduMohanty modified the milestones: v1.19.0, v1.21.0 May 31, 2018
@anjannath
Copy link
Member

anjannath commented May 31, 2018

So, the driver can be used from the docker-machine binary and works fine.. i attempted to use it from minishift with the centos iso, but will need some changes in the driver side i think..

(avm) DBG | Got an ip: 172.16.101.131
.(avm) DBG | Creating Tar key bundle...
(avm) DBG | executing: /usr/bin/vmrun -gu docker -gp  directoryExistsInGuest /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx /var/lib/boot2docker
.........................................................(avm) DBG | Error: The VMware Tools are not running in the virtual machine: /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx
(avm) DBG | executing: /usr/bin/vmrun -gu docker -gp  CopyFileFromHostToGuest /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx /home/redhat/.minishift/profiles/avm/machines/avm/userdata.tar /home/docker/userdata.tar
...............................(avm) DBG | Error: The VMware Tools are not running in the virtual machine: /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx
(avm) DBG | executing: /usr/bin/vmrun -gu docker -gp  runScriptInGuest /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx /bin/sh sudo sh -c "tar xvf /home/docker/userdata.tar -C /home/docker > /var/log/userdata.log 2>&1 && chown -R docker:staff /home/docker"
........................(avm) DBG | Error: The VMware Tools are not running in the virtual machine: /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx
(avm) DBG | executing: /usr/bin/vmrun -gu docker -gp  runScriptInGuest /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx /bin/sh sudo /bin/mv /home/docker/userdata.tar /var/lib/boot2docker/userdata.tar
....................(avm) DBG | Error: The VMware Tools are not running in the virtual machine: /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx
(avm) DBG | executing: /usr/bin/vmrun -gu docker -gp  enableSharedFolders /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx
...................(avm) DBG | Error: The VMware Tools are not running in the virtual machine: /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx

executing the vmrun command directly i get this error.. maybe the version of vmrun has changed the command syntax..

bash-4.3$ vmrun -gu docker -gp  directoryExistsInGuest /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx /var/lib/boot2docker
Error: Unrecognized command: /home/redhat/.minishift/profiles/avm/machines/avm/avm.vmx

With the b2d iso the ssh fails, and i don't see the creation of ssh key steps in the debug logs.

anjannath added a commit to anjannath/minishift that referenced this issue Jun 1, 2018
     - github.com/machine-drivers/docker-machine-driver-vmware
anjannath added a commit to anjannath/minishift that referenced this issue Jun 1, 2018
     - github.com/machine-drivers/docker-machine-driver-vmware
@anjannath anjannath self-assigned this Jun 1, 2018
@LalatenduMohanty LalatenduMohanty modified the milestones: v1.22.0, v1.23.0 Jul 31, 2018
anjannath added a commit to anjannath/minishift that referenced this issue Aug 6, 2018
     - github.com/machine-drivers/docker-machine-driver-vmware
@stale
Copy link

stale bot commented Oct 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants