Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message "Pulling the Openshift Container Image . EXISTS" not required when OpenShift image exists #2537

Closed
LalatenduMohanty opened this issue Jul 2, 2018 · 2 comments

Comments

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Jul 2, 2018

General information

I feel -- Pulling the Openshift Container Image . EXISTS is not required in the console output when the image already exists.

Steps to reproduce

  1. $ minishift start

Expected

$ minishift start
xxxx
   Importing 'openshift/origin:v3.9.0' .......... OK
   Importing 'openshift/origin-docker-registry:v3.9.0' .. OK
   Importing 'openshift/origin-haproxy-router:v3.9.0' .. OK
-- OpenShift cluster will be configured with ...
   Version: v3.9.0
-- Copying oc binary from the OpenShift container image to VM .... OK

Actual

$ minishift start
xxxxx
   Importing 'openshift/origin:v3.9.0' .......... OK
   Importing 'openshift/origin-docker-registry:v3.9.0' .. OK
   Importing 'openshift/origin-haproxy-router:v3.9.0' .. OK
-- OpenShift cluster will be configured with ...
   Version: v3.9.0
-- Pulling the Openshift Container Image . EXISTS
-- Copying oc binary from the OpenShift container image to VM .... OK
@LalatenduMohanty LalatenduMohanty self-assigned this Jul 2, 2018
LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Jul 2, 2018
…oc binary

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@praveenkumar
Copy link
Contributor

@LalatenduMohanty That was specifically what @gbraad asked when I put the PR so I am not sure removing it now make sense?

@gbraad
Copy link
Member

gbraad commented Jul 3, 2018

This is debug information... perhaps it can be moved to -v5 or infolog instead?

So, in a sense you want to remove the message, but when I do not use image-caching, I would still need a form of debug to determine the right thing happened ... else the following statement (copy) will fail, which brings us back to the original issue.

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Jul 3, 2018
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Jul 3, 2018
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Jul 5, 2018
…o verbose

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
praveenkumar pushed a commit that referenced this issue Jul 6, 2018
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty LalatenduMohanty added this to the v1.21.0 milestone Jul 10, 2018
rhnvrm pushed a commit to rhnvrm/minishift that referenced this issue Oct 23, 2018
…o verbose

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants