Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong instructions on developing doc #294

Closed
cmoulliard opened this issue Jan 14, 2017 · 4 comments
Closed

Wrong instructions on developing doc #294

cmoulliard opened this issue Jan 14, 2017 · 4 comments

Comments

@cmoulliard
Copy link

On MacOS with go version go1.6.2 darwin/amd64, the commands to be used to prepare the project in order to build are

  1. Glide
glide install -v --strip-vcs

and not

make vendor
glide install -v
[ERROR]	--strip-vendor cannot be used without --strip-vcs
make: *** [vendor] Error 1
  1. Run
./out/darwin-amd64/minishift version
Minishift version: 1.0.0-beta.2

and not

./out/minishift start
@gbraad
Copy link
Member

gbraad commented Jan 16, 2017

Thanks for the report. Yes, the current documentation does not reflect the current process. We are in the process of updating this and adding instructions for platforms other than OSX.

Files affected:

  • https://github.com/minishift/minishift/blob/master/docs/developing.md

To @cmoulliard: (off-topic) I notice you use Go 1.6.2. We are currently building binaries using 1.7.1. If things are not working as expected, please update your Go distribution first.

@hferentschik hferentschik changed the title developing doc - improvement Wrong instructions on developing doc Jan 16, 2017
@hferentschik
Copy link
Member

@cmoulliard, regarding Glide, the target you want to execute is 'make vendor' which under the hood calls glide. As @gbraad pointed out, you seem to have an outdated development environment. What is your version of Glide? Mine is v0.12.3 and if I set the '--strop-vcs' flag I get:

 [WARN]	The --strip-vcs flag is deprecated. This now works by default.

Maybe we want to add a note, about expected versions in this case. The target itself is correct though.

The minishift binary, though, is in indeed in a different directory now. This changed when we switched to releasing archive bundles instead of single binaries. I am going to update this, since I also have a couple of other things I want to add.

@hferentschik hferentschik self-assigned this Jan 16, 2017
@hferentschik hferentschik added this to the v1.0.0-beta.3 milestone Jan 16, 2017
@gbraad
Copy link
Member

gbraad commented Jan 16, 2017

@hferentschik I did not have this problem with glide (edited: I specifically also install the version referenced by http://glide.sh/version Currently shows v0.12.3). Was pushing the other change already

gbraad added a commit to gbraad-redhat/minishift that referenced this issue Jan 16, 2017
@hferentschik
Copy link
Member

Resolved via pull request #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants