Issue #2234 remove flags for metrics, logging and service catalog #2241
Conversation
LalatenduMohanty
changed the title
gbraad
force-pushed
the
no-metrics+logging
branch
from
36db0b8
to
62fcf69
Compare
gbraad
changed the title
|
@gbraad Since now your removed the flags so might be need to remove those things from the integration feature file also, currently CI is failing for same. |
| @@ -605,9 +605,6 @@ func initClusterUpFlags() *flag.FlagSet { | |||
| clusterUpFlagSet.AddFlag(cmdUtil.HttpsProxyFlag) | |||
|
|
|||
| if minishiftConfig.EnableExperimental { | |||
| clusterUpFlagSet.Bool(configCmd.Metrics.Name, false, "Install metrics (experimental)") | |||
| clusterUpFlagSet.Bool(configCmd.Logging.Name, false, "Install logging (experimental)") | |||
| clusterUpFlagSet.Bool(configCmd.ServiceCatalog.Name, false, "Install service catalog (experimental)") | |||
There was a problem hiding this comment.
We also need to update the integration test case as well, as of now failing for CI.
gbraad
changed the title
…talog See openshift/origin#19209 for more info
gbraad
force-pushed
the
no-metrics+logging
branch
from
62fcf69
to
8e94b73
Compare
| @@ -71,11 +71,8 @@ var ( | |||
| HostPvDir = createConfigSetting("host-pv-dir", SetString, []setFn{validations.IsValidPath}, nil, true, nil) | |||
| ServerLogLevel = createConfigSetting("server-loglevel", SetInt, []setFn{validations.IsPositive}, nil, true, nil) | |||
| OpenshiftEnv = createConfigSetting("openshift-env", nil, nil, nil, false, nil) | |||
| Metrics = createConfigSetting("metrics", SetBool, nil, nil, true, nil) | |||
| Logging = createConfigSetting("logging", SetBool, nil, nil, true, nil) | |||
|
|
||
| // future enabled flags | ||
| ServiceCatalog = createConfigSetting("service-catalog", SetBool, nil, nil, true, nil) |
| | skip-registry-check | f | false | | ||
| | skip-registration | F | false | | ||
| | skip-registry-check | 0 | false | | ||
| | skip-registration | f | false | |
| | logging | TRuE | | ||
| | metrics | positive | | ||
| | metrics | yes | | ||
| | skip-registration | TRuE | |
|
@minishift/minishift-dev AFAIK Users need these features need these from Minishift. So IMO we need to provide them in future. May be after the |
|
Since they are experimental, it is possible for us to remove a feature when
we see fit.
At the moment we have to many issues resulting from this, and we have no
support story.
|
@gbraad That was not my point. I am fine with removing it time being. But this needs to be fixed after oc cluster up restructure happens. |
|
I doubt if WE can ever fix this. it would better to solve this as an addon
and pass the repsonsibility to the actual implementers.
I do not even think it should live inside of `o cluster up` as an 'add'
option... unless it works like an addon.
|
I do not think we have any option here i.e. get away with not fixing it. But we will get the input from concerned people. |
See openshift/origin#19209 for more info
See #2248 for more info
/cc: @deads2k @jcantrill