Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2482 Add minishift ssh user to addon default context #2487

Closed
wants to merge 1 commit into from
Closed

Issue #2482 Add minishift ssh user to addon default context #2487

wants to merge 1 commit into from

Conversation

praveenkumar
Copy link
Contributor

With this PR now registry route will work for generic driver also.

@LalatenduMohanty
Copy link
Member

@praveenkumar I faced this while testing the PR

$ minishift addon apply registry-route
-- Applying addon 'registry-route':....Error applying the add-on: Error executing command 'ssh command error:
command : sudo chown docker /etc/docker/certs.d/docker-registry-default.209.97.133.6.nip.io
err     : exit status 1
output  : chown: invalid user: ‘docker’

@LalatenduMohanty
Copy link
Member

@praveenkumar I faced this while testing the PR

Nvm, I need to update the add-on too.

LalatenduMohanty
LalatenduMohanty requested changes Jun 22, 2018
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except the description.

docs/source/using/addons.adoc Outdated
@@ -160,6 +160,9 @@ The following table shows these variables.

|addon-name
|Name of the current add-on.

|user
|Name of {project} ssh user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Name of {project} ssh user/User used by {project} for execution of commands through ssh/

@minishift/minishift-dev any better suggestions.

LalatenduMohanty
LalatenduMohanty reviewed Jun 25, 2018
View reviewed changes
docs/source/using/addons.adoc
@@ -160,6 +160,9 @@ The following table shows these variables.

|addon-name
|Name of the current add-on.

|user
|User used by {project} for execution of commands through ssh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick: . full stop missing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle it during the merge, I am not going to run complete CI for this now.

LalatenduMohanty
LalatenduMohanty approved these changes Jun 25, 2018
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@LalatenduMohanty
Copy link
Member

Merged in 5999bea

@LalatenduMohanty LalatenduMohanty mentioned this pull request Jun 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@praveenkumar @LalatenduMohanty