Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3051 Remove b2d iso support completely #3052

Merged
merged 1 commit into from Dec 12, 2018

Conversation

anjannath
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #3052 into master will decrease coverage by 1.8%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3052      +/-   ##
==========================================
- Coverage   28.23%   26.43%   -1.81%     
==========================================
  Files         150      150              
  Lines        7756     7752       -4     
==========================================
- Hits         2190     2049     -141     
- Misses       5283     5449     +166     
+ Partials      283      254      -29
Impacted Files Coverage Δ
pkg/minishift/util/iso_path.go 100% <ø> (ø) ⬆️
pkg/minikube/constants/constants.go 44.44% <ø> (ø) ⬆️
cmd/minishift/cmd/start.go 19.79% <100%> (-0.34%) ⬇️
pkg/util/github/github.go 4.83% <0%> (-58.46%) ⬇️
.../minishift/openshift/version/openshift_versions.go 50% <0%> (-22.86%) ⬇️

@gbraad
Copy link
Member

gbraad commented Dec 6, 2018

Lgtm, but no CentOS CI?

@anjannath
Copy link
Member Author

The centos ci job failed while deploying nodejs-ex, i know that's a known failure, but the error msg looked different than before, so triggered it again, just to be sure!

@gbraad
Copy link
Member

gbraad commented Dec 11, 2018

@anjannath what is up with CentOS CI ?

I think this should be merged ASAP

@anjannath
Copy link
Member Author

anjannath commented Dec 11, 2018 via email

@anjannath
Copy link
Member Author

@gbraad centos ci is stuck at the gofmt error once #3060 is merged it'll be fixed.

@anjannath
Copy link
Member Author

retest this please

@LalatenduMohanty LalatenduMohanty merged commit b21ac83 into minishift:master Dec 12, 2018
@LalatenduMohanty
Copy link
Member

Thanks @anjannath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants