Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANPL-1350 Backend python package upgrade #1099

Merged
merged 7 commits into from Dec 8, 2022

Conversation

ymao2
Copy link
Contributor

@ymao2 ymao2 commented Dec 6, 2022

πŸ“ Summary

This PR closes/completes/contributes to issue #ANPL-1350

The main changes I made are for django-channel

other

  • get_event_loop has been deprecated since python 3.10, recommend to use get_running_loop

Merging this PR will have the following side-effects:

  • No

πŸ” What should the reviewer concentrate on?

Changes on codes

πŸ§‘β€πŸ’» How should the reviewer test these changes?

  • make sure your python version under local >=3.8 as required by Django 4.X
  • general regression tests

πŸ“š Documentation status

  • No changes to the documentation are required
  • This PR includes all relevant documentation
  • Documentation will be added in the future because ... (see #ANPL-...)

Copy link
Contributor

@rossjones rossjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ymao2 ymao2 merged commit a8c3f87 into main Dec 8, 2022
@ymao2 ymao2 deleted the anpl-1350-backend-package-upgrade branch December 8, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants