Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Commit

Permalink
Rename S3 bucket output to be consistent
Browse files Browse the repository at this point in the history
When we create cloudformation things we can create Outputs that represent them,
which then get turned into grains, meaning that we can do lookups on randomly
named resources. The buckets that are created have 2 things, a name, and a policy.
The output for the S3 bucket currently is named like it references the policy,
but actually it references the name. This change makes it more coherent with the
form '<bucket_id>BucketName'.
  • Loading branch information
Niall Creech committed Aug 22, 2016
1 parent 802b717 commit 45d0f79
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bootstrap_cfn/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ def create_s3_bucket(self, bucket_config, template):
# Add the bucket name to the list of cloudformation
# outputs
template.add_output(Output(
"{}Policy".format(bucket_name),
"{}BucketName".format(bucket_name),
Description="S3 bucket name",
Value=Ref(bucket)
))
Expand Down

0 comments on commit 45d0f79

Please sign in to comment.