Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Commit

Permalink
Make db-name field optional for sqlserver based RDS instances
Browse files Browse the repository at this point in the history
Ideally we'd actually make the field required to be not set for these
types of DB servers but that is more work
  • Loading branch information
ashb committed Aug 12, 2015
1 parent f0562f9 commit bd25b8b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
@@ -1,6 +1,9 @@
## Version UNRELEASED

* Update the AWS AMI to the latest ubuntu, which includes the new kernel.
* Partially support sqlserver based RDS instances - which *cannot* have a
DBName specified, so make that field not required for sqlserver backed
instances.

## Version 0.5.7

Expand Down
4 changes: 4 additions & 0 deletions bootstrap_cfn/config.py
Expand Up @@ -372,6 +372,10 @@ def rds(self, template):
)
resources.append(rds_instance)

# We *cant* specify db-name for SQL Server based RDS instances. :(
if 'db-engine' in self.data['rds'] and self.data['rds']['db-engine'].startswith("sqlserver"):
required_fields.pop('db-name')

# TEST FOR REQUIRED FIELDS AND EXIT IF MISSING ANY
for yaml_key, rds_prop in required_fields.iteritems():
if yaml_key not in self.data['rds']:
Expand Down

0 comments on commit bd25b8b

Please sign in to comment.