added custom s3 policy tests

ministryofjustice · Apr 14, 2015 · c41e14a · c41e14a
1 parent 83b6c1b
commit c41e14a
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/tests/sample-custom-s3-policy.json b/tests/sample-custom-s3-policy.json
@@ -0,0 +1,5 @@
+{   "Action": ["s3:Get*", "s3:Put*", "s3:List*", "s3:Delete*"],
+    "Resource": "arn:aws:s3:::moj-test-dev-static/*",
+    "Effect": "Allow",
+    "Principal": { "AWS": "*" }
+}
diff --git a/tests/tests.py b/tests/tests.py
@@ -105,6 +105,33 @@ def test_s3(self):
         config = ConfigParser(ProjectConfig('tests/sample-project.yaml', 'dev').config, 'my-stack-name')
         self.assertEquals(known, config.s3())
 
+    def test_custom_s3_policy(self):
+        expected_s3 = [
+            {
+                'Action': [
+                    's3:Get*',
+                    's3:Put*',
+                    's3:List*',
+                    's3:Delete*'],
+                'Resource': 'arn:aws:s3:::moj-test-dev-static/*',
+                            'Effect': 'Allow',
+                            'Principal': {'AWS': '*'}
+            }
+        ]
+
+        project_config = ProjectConfig('tests/sample-project.yaml', 'dev')
+
+        project_config.config['s3'] = {
+            'static-bucket-name': 'moj-test-dev-static',
+            'policy': 'tests/sample-custom-s3-policy.json'}
+
+        config = ConfigParser(project_config.config, 'my-stack-name')
+        s3_cfg = config.s3()
+        s3_custom_cfg = s3_cfg['StaticBucketPolicy'][
+            'Properties']['PolicyDocument']['Statement']
+
+        compare(expected_s3, s3_custom_cfg)
+
     def test_rds(self):
         known = {
             'DBSecurityGroup': {