Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Commit

Permalink
Fix ACM alternative name tests
Browse files Browse the repository at this point in the history
ACM needs separate domain validation options for each subject
alternative name. This is fixed in another PR, this change updates
the checks to reflect this.
  • Loading branch information
Niall Creech committed Feb 24, 2017
1 parent 3544382 commit f50eab9
Showing 1 changed file with 15 additions and 5 deletions.
20 changes: 15 additions & 5 deletions tests/test_acm.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,25 @@ def test_acm(self):
]
subject_alternative_names = ['goodbye.test.dsd.io', 'hello_again.test.dsd.io']

domain_validation_options = DomainValidationOption(
DomainName=domain_name,
ValidationDomain=validation_domain
)
domain_validation_options = [
DomainValidationOption(
DomainName=domain_name,
ValidationDomain=validation_domain
),
DomainValidationOption(
DomainName=subject_alternative_names[0],
ValidationDomain=validation_domain
),
DomainValidationOption(
DomainName=subject_alternative_names[1],
ValidationDomain=validation_domain
)
]
ACMCertificate = Certificate(
certificate_name,
DomainName=domain_name,
SubjectAlternativeNames=subject_alternative_names,
DomainValidationOptions=[domain_validation_options],
DomainValidationOptions=domain_validation_options,
Tags=tags
)
certificate_cfg = [config_parser._get_acm_certificate(certificate_name)]
Expand Down

0 comments on commit f50eab9

Please sign in to comment.