This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
allow elb names with '.' #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You also need to modify the line where ELB name is assigned: template['ElasticLoadBalancer']['Properties']['LoadBalancerName'] = 'ELB-%s' % elb['name']ELB name is populated with the same value as DNS zone entry - or rather it's the other way around. Point being ELB name can not contain dots because of AWS dramas... |
ashb
force-pushed
the
allow_elb_names_with_dots
branch
from
75e6aa3
to
04e000a
Compare
ashb
force-pushed
the
allow_elb_names_with_dots
branch
from
04e000a
to
fd353f8
Compare
kyriakosoikonomakos
added a commit
that referenced
this pull request
Feb 26, 2015
allow elb names with '.'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.