Core multiple stacks management #215

yufangzhang · 2016-07-04T16:08:43Z

Modify fab task cfn_create, cfn_delete to mange multiple stacks.
Create task set_active_stack(tag) to switch among stacks
Add unit tests for new methods

coveralls · 2016-07-04T16:12:14Z

Coverage decreased (-3.4%) to 48.066% when pulling aeacbc9 on create_multiple_stacks into 11b3fed on master.

coveralls · 2016-07-04T16:16:29Z

Coverage decreased (-3.4%) to 48.066% when pulling 59d15be on create_multiple_stacks into 11b3fed on master.

mattpep · 2016-07-05T09:30:08Z

bootstrap_cfn/fab_tasks.py

+    """
+    r53_conn = get_connection(R53)
+    zone_id = get_zone_id()
+    record = "{}".format(get_tag_record_name(stack_tag))


This could probably be simply:

record = get_tag_record_name(stack_tag)

i.e. without the call to format.

sevenmachines · 2016-07-08T07:47:58Z

@yufangzhang happy to merge after those couple of minor things @mattpep mentioned are fixedup!

yufangzhang · 2016-07-08T15:42:53Z

@mattpep I've done the changes. can you have a look ~?

coveralls · 2016-07-08T15:43:46Z

Coverage decreased (-3.3%) to 48.157% when pulling 5136661 on create_multiple_stacks into 11b3fed on master.

sevenmachines · 2016-07-11T17:33:10Z

@mattpep @yufangzhang we happy to merge?

mattpep · 2016-07-12T11:35:27Z

LGTM. Ideally we should squash the fixup commit into the one it updates. Then it's good to merge.

filipposc5 · 2016-07-12T18:21:02Z

bootstrap_cfn/fab_tasks.py

+    Args:
+        stack_tag: the tag of stack
+    Returns:
+        True if stack exists


Is this accurate? To be specific does it return "True" if stack exists?

yufangzhang · 2016-07-13T15:48:08Z

@mattpep yeup, updated!

mattpep · 2016-07-13T16:01:06Z

The first bullet point of this PR makes reference to changing the task cfn_create but I see no changes of that task within config.py.
Does the stack_id now have to be specified? More generically, it'd be useful for the documentation be updated to explain how these new tasks work.

coveralls · 2016-07-13T16:16:45Z

Coverage decreased (-3.4%) to 48.159% when pulling c084386 on create_multiple_stacks into b24ca77 on master.

yufangzhang · 2016-07-13T16:22:52Z

@mattpep we generate stack_id from uuid in set_stack_name at the beginning as what it used to be, then add it to stack_name. In config.py, we only added self.stack_id as instance variable in config and changed the format of dns record name.

coveralls · 2016-07-26T13:15:06Z

Changes Unknown when pulling 7d5479e on create_multiple_stacks into * on master*.

coveralls · 2016-07-27T09:07:11Z

Changes Unknown when pulling b3bc543 on create_multiple_stacks into * on master*.

coveralls · 2016-07-27T13:54:15Z

Changes Unknown when pulling f34f0f4 on create_multiple_stacks into * on master*.

cliffxuan · 2016-08-04T14:49:58Z

bootstrap_cfn/fab_tasks.py

-    r53_conn = get_connection(R53)
-    zone_name = cfn_config.data.get('master_zone', None)
+    record = "{}.{}".format(get_tag_record_name(stack_tag), zone_name)
+    logger.info("fab_tasks::set_stack_name: "


format is better than using %s in formatting a string, however, in logging, %s is actually preferred, so you would do:

logger.info("Creating stack suffix '%s' for record '%s'... %s...", stack_suffix, record, zone_id)

coveralls · 2016-08-08T16:50:19Z

Changes Unknown when pulling 1df9b52 on create_multiple_stacks into * on master*.

coveralls · 2016-08-08T16:57:13Z

Changes Unknown when pulling b88af34 on create_multiple_stacks into * on master*.

yufangzhang · 2016-08-08T16:57:52Z

@cliffxuan Thanks for the advice Cliff! I've made some changes to make it more pythonic 👻
@lukaszraczylo think you may have used this to do the CCCD stuff? I've just updated a bug on deleting active stack records. hopefully you haven't come across that....
@filipposc5 @niallcreech I think this beast is ready to be merged, can anyone have a look? sorry about its size :P

Test starts failing with the error below, which is fixed in 2a595f1 (aka version 0.9 unreleased): ``` Traceback (most recent call last): File "/Users/yufang/.virtualenvs/test/bin/flake8", line 11, in <module> sys.exit(main()) File "/Users/yufang/.virtualenvs/test/lib/python2.7/site-packages/flake8/main/cli.py", line 16, in main app.run(argv) File "/Users/yufang/.virtualenvs/test/lib/python2.7/site-packages/flake8/main/application.py", line 316, in run self._run(argv) File "/Users/yufang/.virtualenvs/test/lib/python2.7/site-packages/flake8/main/application.py", line 299, in _run self.initialize(argv) File "/Users/yufang/.virtualenvs/test/lib/python2.7/site-packages/flake8/main/application.py", line 290, in initialize self.register_plugin_options() File "/Users/yufang/.virtualenvs/test/lib/python2.7/site-packages/flake8/main/application.py", line 150, in register_plugin_options self.check_plugins.register_options(self.option_manager) File "/Users/yufang/.virtualenvs/test/lib/python2.7/site-packages/flake8/plugins/manager.py", line 451, in register_options list(self.manager.map(register_and_enable)) File "/Users/yufang/.virtualenvs/test/lib/python2.7/site-packages/flake8/plugins/manager.py", line 261, in map yield func(self.plugins[name], *args, **kwargs) File "/Users/yufang/.virtualenvs/test/lib/python2.7/site-packages/flake8/plugins/manager.py", line 447, in register_and_enable call_register_options(plugin) File "/Users/yufang/.virtualenvs/test/lib/python2.7/site-packages/flake8/plugins/manager.py", line 357, in generated_function return method(optmanager, *args, **kwargs) File "/Users/yufang/.virtualenvs/test/lib/python2.7/site-packages/flake8/plugins/manager.py", line 207, in register_options add_options(optmanager) File "/Users/yufang/.virtualenvs/test/lib/python2.7/site-packages/flake8_import_order/flake8_linter.py", line 32, in add_options parser.config_options.append("application-import-names") AttributeError: 'OptionManager' object has no attribute 'config_options' ```

update cfn_create + cfn_delete with multiple stacks support add set_active_stack fab task

Add unittest on newly added methods.

coveralls · 2016-08-10T15:25:47Z

Changes Unknown when pulling e920fc1 on create_multiple_stacks into * on master*.

yufangzhang added the ready for review label Jul 4, 2016

yufangzhang force-pushed the create_multiple_stacks branch from 934d86c to aeacbc9 Compare July 4, 2016 16:10

yufangzhang force-pushed the create_multiple_stacks branch from aeacbc9 to 59d15be Compare July 4, 2016 16:14

mattpep reviewed Jul 5, 2016
View reviewed changes

filipposc5 reviewed Jul 12, 2016
View reviewed changes

yufangzhang force-pushed the create_multiple_stacks branch from 5136661 to 28db73d Compare July 13, 2016 15:46

yufangzhang force-pushed the create_multiple_stacks branch from 28db73d to c084386 Compare July 13, 2016 16:12

yufangzhang force-pushed the create_multiple_stacks branch 3 times, most recently from 1d167ad to 7d5479e Compare July 26, 2016 13:13

yufangzhang force-pushed the create_multiple_stacks branch from 03d1037 to b3bc543 Compare July 27, 2016 09:05

yufangzhang force-pushed the create_multiple_stacks branch 2 times, most recently from dcd5228 to f34f0f4 Compare July 27, 2016 13:48

yufangzhang changed the title ~~[WIP] Core multiplestacks operations~~ [WIP] Core multiple stacks management Jul 27, 2016

yufangzhang changed the title ~~[WIP] Core multiple stacks management~~ Core multiple stacks management Jul 27, 2016

cliffxuan reviewed Aug 4, 2016
View reviewed changes

yufangzhang force-pushed the create_multiple_stacks branch from 1df9b52 to b88af34 Compare August 8, 2016 16:53

yufangzhang added 3 commits August 10, 2016 16:15

Add parallel stack support

3ece150

update cfn_create + cfn_delete with multiple stacks support add set_active_stack fab task

Add unittest for multiple stacks

e920fc1

Add unittest on newly added methods.

yufangzhang force-pushed the create_multiple_stacks branch from b88af34 to e920fc1 Compare August 10, 2016 15:18

ezman merged commit d917519 into master Aug 10, 2016

ezman removed the ready for review label Aug 10, 2016

mattpep deleted the create_multiple_stacks branch August 11, 2016 09:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core multiple stacks management #215

Core multiple stacks management #215

yufangzhang commented Jul 4, 2016 •

edited

Loading

coveralls commented Jul 4, 2016

coveralls commented Jul 4, 2016

mattpep Jul 5, 2016

sevenmachines commented Jul 8, 2016

yufangzhang commented Jul 8, 2016

coveralls commented Jul 8, 2016

sevenmachines commented Jul 11, 2016

mattpep commented Jul 12, 2016

filipposc5 Jul 12, 2016 •

edited

Loading

yufangzhang commented Jul 13, 2016

mattpep commented Jul 13, 2016 •

edited

Loading

coveralls commented Jul 13, 2016

yufangzhang commented Jul 13, 2016

coveralls commented Jul 26, 2016

coveralls commented Jul 27, 2016

coveralls commented Jul 27, 2016 •

edited

Loading

cliffxuan Aug 4, 2016 •

edited

Loading

coveralls commented Aug 8, 2016

coveralls commented Aug 8, 2016

yufangzhang commented Aug 8, 2016

coveralls commented Aug 10, 2016

Core multiple stacks management #215

Core multiple stacks management #215

Conversation

yufangzhang commented Jul 4, 2016 • edited Loading

coveralls commented Jul 4, 2016

coveralls commented Jul 4, 2016

mattpep Jul 5, 2016

Choose a reason for hiding this comment

sevenmachines commented Jul 8, 2016

yufangzhang commented Jul 8, 2016

coveralls commented Jul 8, 2016

sevenmachines commented Jul 11, 2016

mattpep commented Jul 12, 2016

filipposc5 Jul 12, 2016 • edited Loading

Choose a reason for hiding this comment

yufangzhang commented Jul 13, 2016

mattpep commented Jul 13, 2016 • edited Loading

coveralls commented Jul 13, 2016

yufangzhang commented Jul 13, 2016

coveralls commented Jul 26, 2016

coveralls commented Jul 27, 2016

coveralls commented Jul 27, 2016 • edited Loading

cliffxuan Aug 4, 2016 • edited Loading

Choose a reason for hiding this comment

coveralls commented Aug 8, 2016

coveralls commented Aug 8, 2016

yufangzhang commented Aug 8, 2016

coveralls commented Aug 10, 2016

yufangzhang commented Jul 4, 2016 •

edited

Loading

filipposc5 Jul 12, 2016 •

edited

Loading

mattpep commented Jul 13, 2016 •

edited

Loading

coveralls commented Jul 27, 2016 •

edited

Loading

cliffxuan Aug 4, 2016 •

edited

Loading