Add KeyName to fab parameters #226
Conversation
yufangzhang
force-pushed
the
add_keyname_to_fab_parameters
branch
from
2ab963d
to
613d7b3
Compare
yufangzhang
changed the title
yufangzhang
force-pushed
the
add_keyname_to_fab_parameters
branch
from
f23df4a
to
e6535b2
Compare
|
Changes Unknown when pulling e6535b2 on add_keyname_to_fab_parameters into * on master*. |
yufangzhang
changed the title
| # if _validate_fabric_env() is called by cfn_create, then check keyname. | ||
| # otherwise not. | ||
| if called_by_cfn_create: | ||
| if env.keyname is None: |
There was a problem hiding this comment.
Could you please put them on the same line?
yufangzhang
force-pushed
the
add_keyname_to_fab_parameters
branch
from
e6535b2
to
71f01eb
Compare
|
Changes Unknown when pulling 71f01eb on add_keyname_to_fab_parameters into * on master*. |
| # otherwise not. | ||
| if called_by_cfn_create and env.keyname is None: | ||
| sys.exit("\n[ERROR] Please specify a keyname, e.g 'keyname:keyops'") | ||
|
|
There was a problem hiding this comment.
I can appreciate why it's a good idea to mandate it, but, this is a breaking change. A reasonable compromise might be to accept that some stacks have it defined in their config, and warn rather than error. Also, deleting the keyname from the template-deploy example?
There was a problem hiding this comment.
do you mean it's better to accept the param in both config file and command line, or just warn if it's defined in config rather than fab params?
There was a problem hiding this comment.
Maybe accept it if its in the config, but warning that it's deprecated/not-advised. whatever
Only a suggestion to think about though, it's not a requirement. If you're sure this is the best way then fire on
|
Changes Unknown when pulling 251e6df on add_keyname_to_fab_parameters into * on master*. |
yufangzhang
force-pushed
the
add_keyname_to_fab_parameters
branch
from
251e6df
to
186d829
Compare
- This commit adds keyname as a fab parameter. with it, you can set it to your keypair in AWS KeyName defined in config file will overided by fab command. - keyname is mandatory fab parameter in cfn_create, but not in others - README and unittests updated
yufangzhang
force-pushed
the
add_keyname_to_fab_parameters
branch
from
85f8563
to
fd0e59c
Compare
|
Changes Unknown when pulling fd0e59c on add_keyname_to_fab_parameters into * on master*. |
This commit adds keyname as a fab parameter.
with it, you can set it to your keypair in AWS
KeyName defined in config file will not be used.