Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Make sure that set_active_stack activates all ELBs. #234

Merged
merged 1 commit into from
Dec 2, 2016
Merged

Make sure that set_active_stack activates all ELBs. #234

merged 1 commit into from
Dec 2, 2016

Conversation

kwilczynski
Copy link
Contributor

Signed-off-by: Krzysztof Wilczynski krzysztof.wilczynski@linux.com

@kwilczynski kwilczynski changed the title Make sure that set_active_stack activates all ELBs. [WIP] Make sure that set_active_stack activates all ELBs. Nov 25, 2016
@kwilczynski
Copy link
Contributor Author

kwilczynski commented Nov 25, 2016 •
edited

To be completed:

  • Modify set_active_stack to work with multiple public ELBs
  • Locate other places in the code where get_first_public_elb() is also invoked
    • Modify cfn_delete to remove DNS entries for all ELBs
    • Modify get_active_stack to work with all ELBs
  • Handle "dualstack" fully-qualified URLs
  • Update unit tests
  • Test using single and multiple ELBs stacks

@kwilczynski
Copy link
Contributor Author

@ltsampros @yufangzhang hi there! Please review.

@kwilczynski kwilczynski changed the title [WIP] Make sure that set_active_stack activates all ELBs. Make sure that set_active_stack activates all ELBs. Nov 28, 2016
@kwilczynski kwilczynski self-assigned this Nov 28, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8e9d368 on kwilczynski:feature/update-set_active_stack into ** on ministryofjustice:master**.

@kwilczynski
Copy link
Contributor Author

More things need to be done in here as per the new requirements from @yufangzhang.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b7c0de6 on kwilczynski:feature/update-set_active_stack into ** on ministryofjustice:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a38a063 on kwilczynski:feature/update-set_active_stack into ** on ministryofjustice:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4d0beda on kwilczynski:feature/update-set_active_stack into ** on ministryofjustice:master**.

@kwilczynski kwilczynski force-pushed the feature/update-set_active_stack branch from 4d0beda to 0ccfebf Compare November 29, 2016 18:12
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0ccfebf on kwilczynski:feature/update-set_active_stack into ** on ministryofjustice:master**.

@kwilczynski kwilczynski force-pushed the feature/update-set_active_stack branch from 0ccfebf to e8c8fa1 Compare November 29, 2016 21:41
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e8c8fa1 on kwilczynski:feature/update-set_active_stack into ** on ministryofjustice:master**.

@kwilczynski kwilczynski force-pushed the feature/update-set_active_stack branch from e8c8fa1 to 962790e Compare November 30, 2016 15:18
@kwilczynski kwilczynski force-pushed the feature/update-set_active_stack branch from ef7d024 to 2ab4a9f Compare December 1, 2016 12:40
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2ab4a9f on kwilczynski:feature/update-set_active_stack into ** on ministryofjustice:master**.

@kwilczynski
Make sure that set_active_stack activates all ELBs.
2ab4a9f 
Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
@ltsampros
Copy link
Contributor

Looks good to me! @kwilczynski

@ltsampros ltsampros merged commit 426e406 into ministryofjustice:master Dec 2, 2016
@kwilczynski kwilczynski deleted the feature/update-set_active_stack branch March 18, 2018 22:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kwilczynski kwilczynski

Labels
enhancement template-deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kwilczynski @coveralls @ltsampros @aldavidson