This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Fix backward compatibility for dns update #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipposc5
force-pushed
the
make-update-record-backwards-compatible
branch
3 times, most recently
from
bd8fc22
to
13f51a4
Compare
Amends the recent changes in r53 update_dns_record so that they do not change the method signature, which broke older clients/fabfiles. Passes elb hosted zones in maintenance as well, although the maintenance feature has not necessarily been fully tested in the current version of bootstrap-cfn. Tests updated.
filipposc5
force-pushed
the
make-update-record-backwards-compatible
branch
from
13f51a4
to
0d0ca99
Compare
filipposc5
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends the recent changes in r53 update_dns_record so that they do
not change the method signature, which broke older clients/fabfiles.
Passes elb hosted zones in maintenance as well, although the
maintenance feature has not necessarily been fully tested in the
current version of bootstrap-cfn. Tests updated.