This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Allow multi-part policies on aditional s3 buckets #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robyoung
force-pushed
the
s3-multi-part-bucket-policy
branch
from
6647f4e
to
098b1c6
Compare
AIM policy documents are made up of a list of policy statements. Currently bootstrap-cfn only allows a single custom policy for an S3 bucket. This change allows a list of custom policies to be provided. Backwards compatibility is maintained by allowing either a single policy dict or a list of policies as an array. I have only implemented this on the additional s3 buckets because the static buckets are for a specific use case and should be kept as simple as possible.
robyoung
force-pushed
the
s3-multi-part-bucket-policy
branch
from
098b1c6
to
5708d08
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIM policy documents are made up of a list of policy statements. Currently bootstrap-cfn only allows a single custom policy for an S3 bucket. This change allows a list of custom policies to be provided. Backwards compatibility is maintained by allowing either a single policy dict or a list of policies.
I have only implemented this on the additional s3 buckets because the static buckets are for a specific use case and should be kept as simple as possible. Do you think it would make more sense to implement it the same for the static bucket and additional buckets?