This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
WIP: Allow logical name to be set on additional buckets #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robyoung
force-pushed
the
s3-logical-resource-id
branch
from
8a58f26
to
31a2fee
Compare
AWS allows buckets to have a logical name as well as a physical name. This feature is used by `upload_assets` to make it easier to perform actions on a kind of bucket within an environment. This is also useful for additional S3 buckets where we need a different bucket per environment. Backwards compatibility is maintained by introducing an additional yaml key for the `logical-name` which overrides the resource name. If it's not set the resource name reverts to the bucket name.
robyoung
force-pushed
the
s3-logical-resource-id
branch
from
31a2fee
to
7b916be
Compare
robyoung
changed the title
|
Apparently the same effect can be achieved by using the cloudformation output. |
robyoung
changed the title
robyoung
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS allows buckets to have a logical name as well as a physical name. This feature is used by
upload_assetsto make it easier to perform actions on a kind of bucket within an environment. This is also useful for additional S3 buckets where we need a different bucket per environment.Backwards compatibility is maintained by introducing an additional yaml key for the
logical-namewhich overrides the resource name. If it's not set the resource name reverts to the bucket name.