This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Support alternative ACM domain domain validation domains #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passes unit tests but going to test on stack so WIP |
sevenmachines
force-pushed
the
support_alternative_domain_name_validation_options
branch
4 times, most recently
from
5f862e4
to
42ecfb9
Compare
This change adds support for the domain_validation_options setting. This means that any subject_alternative_names can have their validation_domain explicitly overriden.
sevenmachines
force-pushed
the
support_alternative_domain_name_validation_options
branch
from
f104fa6
to
427c6a6
Compare
sevenmachines
force-pushed
the
support_alternative_domain_name_validation_options
branch
from
427c6a6
to
922cb88
Compare
sevenmachines
changed the title
|
tested on helloworld stack, looks ok |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the domain_validation_options setting.
This means that any subject_alternative_names can have their
validation_domain explicitly overriden.