This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Refactor fab_tasks file #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were returning more and more things from get_config, not all of which was used everywhere (and we wanted to add 2 more) and that was just getting silly. Most of what we were returning was only used to pass in to EC2 or Cloudformation constructors, so lets just make it easier to create those instances.
I know it was unused because the implementation would end up returning IDs, not IPs.
Including showing us that we have some dead code paths :/
|
LGTM; can we update the Changelog |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was movitated by
get_confighaving multiple return values and both @mattmb and I wanting to add a new (different) value - 5 is too certainly too many.Main changes are:
get_config()now returns just a ConfigParser instanceget_connectionhelper function added to get Cloudformation, EC2, IAM etc connection objectsget_stack_addresses(it was unused cos it didn't do what it said - it returned IDs, not IPs)