Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Fix/custom s3 policy #75

Merged
merged 3 commits into from
Apr 14, 2015
Merged

Fix/custom s3 policy #75

merged 3 commits into from
Apr 14, 2015

Conversation

pidah
Copy link
Contributor

@pidah pidah commented Apr 14, 2015

This bugfix ensures you can apply a custom s3 policy to the cloudformation yaml config.

Connects to #54

@stuartornum
Copy link
Contributor

Does this work for multiple buckets? I like it generally.

However, we don't want people defining S3 storage for things that are critical to keep, for example Tribunal Decisions documents, we don't want to be declaring this within the stack. Purely because if we delete the stack, we delete the documents...

@ashb
Copy link
Contributor

ashb commented Apr 14, 2015

This is just a bug fix on the existing feature that was already there, not a new feature.

It's worth noting that Cloudformation won't let you delete a stack if there are objects in the S3 bucket

@stuartornum
Copy link
Contributor

What I mean is the creation of the S3 bucket for Tribunal decision documents should still be a manual task - therefore not controlled by Cloudformation, as this'll be very dangerous

@stuartornum
Copy link
Contributor

@ashb - thats true about deleting S3 buckets with objects - forgot about that!

stuartornum added a commit that referenced this pull request Apr 14, 2015
@stuartornum stuartornum merged commit 28934a0 into master Apr 14, 2015
@stuartornum stuartornum deleted the fix/custom_s3_policy branch April 14, 2015 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants