Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Enforce PEP8 on any changed hunks. #77

Merged
merged 1 commit into from
Apr 20, 2015
Merged

Enforce PEP8 on any changed hunks. #77

merged 1 commit into from
Apr 20, 2015

Conversation

ashb
Copy link
Contributor

@ashb ashb commented Apr 17, 2015

An enforcable stlye guide is a good thing - we have some developers who are
less experienced with python so being able to say 'do it this way' is a
good thing.

I am open to disabling some more rules (for instance I have set line
lengths to 160 up from the default 79) but not the enforcement of a style.

This change means that we don't have to fix PEP8 style violations in one
big go, and can still get useful automated style checking.

@ashb ashb force-pushed the pep8-on-hunks branch 3 times, most recently from 02b7489 to b12a5c6 Compare April 17, 2015 16:39
@ashb ashb changed the title Enforce PEP8 on any changed hunks. Enforce PEP8 on any changed hunks. (WIP) Apr 17, 2015
@ashb ashb force-pushed the pep8-on-hunks branch 2 times, most recently from 1e46bad to 33c5f73 Compare April 17, 2015 17:03
An enforcable stlye guide is a good thing - we have some developers who
are less experienced with python so being able to say 'do it this way'
is a good thing.

I am open to disabling some more rules (for instance I have set line
lengths to 160 up from the default 79) but not the enforcement of a
style.

This change means that we don't have to fix PEP8 style violations in one
big go, and can still get useful automated style checking.
@ashb ashb removed the in progress label Apr 17, 2015
@ashb ashb changed the title Enforce PEP8 on any changed hunks. (WIP) Enforce PEP8 on any changed hunks. Apr 20, 2015
ciprianc added a commit that referenced this pull request Apr 20, 2015
@ciprianc ciprianc merged commit 583a4e3 into master Apr 20, 2015
@ciprianc ciprianc deleted the pep8-on-hunks branch April 20, 2015 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants