This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Enforce PEP8 on any changed hunks. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
force-pushed
the
pep8-on-hunks
branch
3 times, most recently
from
02b7489
to
b12a5c6
Compare
ashb
changed the title
ashb
force-pushed
the
pep8-on-hunks
branch
2 times, most recently
from
1e46bad
to
33c5f73
Compare
An enforcable stlye guide is a good thing - we have some developers who are less experienced with python so being able to say 'do it this way' is a good thing. I am open to disabling some more rules (for instance I have set line lengths to 160 up from the default 79) but not the enforcement of a style. This change means that we don't have to fix PEP8 style violations in one big go, and can still get useful automated style checking.
ashb
changed the title
ciprianc
added a commit
that referenced
this pull request
Apr 20, 2015
Enforce PEP8 on any changed hunks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An enforcable stlye guide is a good thing - we have some developers who are
less experienced with python so being able to say 'do it this way' is a
good thing.
I am open to disabling some more rules (for instance I have set line
lengths to 160 up from the default 79) but not the enforcement of a style.
This change means that we don't have to fix PEP8 style violations in one
big go, and can still get useful automated style checking.