This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
DNSNAME instead of CanonicalHostedZoneName: #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When *internal* is specified for the ELB scheme, the load balancer doesn't have a **CanonicalHostedZoneName** value. **DNSName** value exists for both *internal* and *internet-facing* ELB schemes.
| @@ -45,7 +45,7 @@ dev: | |||
| Protocol: TCP | |||
| - name: test-dev-internal | |||
| hosted_zone: kyrtest.pf.dsd.io. | |||
| scheme: internet-facing | |||
| scheme: internal | |||
There was a problem hiding this comment.
I tried to get this to work before (internal), but for some reason it wouldn't - does it now?
There was a problem hiding this comment.
Just read the commit notes: Awesome!
ashb
added a commit
that referenced
this pull request
Apr 27, 2015
Use DnsName instead of CanonicalHostedZoneName so internal load balancers work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When internal is specified for the ELB scheme, the
load balancer doesn't have a CanonicalHostedZoneName value.
DNSName value exists for both internal and internet-facing
ELB schemes.