Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

[enable_cert_updates] #97

Merged
merged 1 commit into from
May 7, 2015
Merged

Conversation

sevenmachines
Copy link
Contributor

Fix for a little problem introduced in enable_cert_updates merge

  • Remove deprecated force argument being passed to
    iam::delete_certificate

@mattmb
Copy link
Contributor

mattmb commented May 5, 2015

Cool, thanks. Can you do a git grep force or equivalent (just to check we didn't miss any more)

@sevenmachines sevenmachines force-pushed the fix_deprecated_delete_certificate_force branch from c07b731 to 0bde9a0 Compare May 5, 2015 14:51
@sevenmachines
Copy link
Contributor Author

Made a few little removals to get rid of redundant 'force' entries and avoid confusion

@sevenmachines sevenmachines force-pushed the fix_deprecated_delete_certificate_force branch 3 times, most recently from 417911c to 9793f65 Compare May 6, 2015 15:57
@ashb
Copy link
Contributor

ashb commented May 6, 2015

To test this flake8 behaviour locally make sure you have latest version installed: pip install -U flake8

Then you can test it like this:

git diff origin/master...origin/fix_deprecated_delete_certificate_force | flake8 --diff

- Remove deprecated force argument being passed to
  iam::delete_certificate
- Remove remaining unused force calls to certificate updates
@sevenmachines sevenmachines force-pushed the fix_deprecated_delete_certificate_force branch from 9793f65 to 5e64b3e Compare May 6, 2015 17:31
ashb added a commit that referenced this pull request May 7, 2015
…ertificate_force

Fix for a little problem introduced in enable_cert_updates merge
@ashb ashb merged commit 71c67f0 into master May 7, 2015
@ashb ashb deleted the fix_deprecated_delete_certificate_force branch May 7, 2015 09:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants