Skip to content
This repository has been archived by the owner on Jul 25, 2023. It is now read-only.

BugFix - Add old outgoing type names for earlier integration tests spreadsheet #248

Merged
merged 1 commit into from
May 21, 2020

Conversation

Obsiye
Copy link
Contributor

@Obsiye Obsiye commented May 21, 2020

BugFix

Add old outgoing type names for earlier integration tests spreadsheet

This fixes an error in sentry "ArgumentError Invalid type: outgoings_childcare" instead of outgoings_child_care sent by the master uat branch in Apply

childcare, housing_costs and maintenance type names are retained for compatibility with earlier versions of integration test spreadsheet

Please see in the OutgoingsCreator class under OUTGOING_KLASSES

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase master.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

childcare, housing_costs and maintenance type names are retained for compatibility with earlier versions of integration test spreadsheet

Please see in the OutgoingsCreator class under OUTGOING_KLASSES
@Obsiye Obsiye force-pushed the bug-allow-temporary-outgoing-type-names branch from bc8f773 to ff9eb53 Compare May 21, 2020 14:19
@Obsiye Obsiye changed the title Add old outgoing type names for earlier integration tests spreadsheet BugFix - Add old outgoing type names for earlier integration tests spreadsheet May 21, 2020
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and fix
Maybe create an issue pointing to this PR so that we can come back to it... unless you are going to fix it almost immediately?! 😄

@Obsiye Obsiye merged commit ef70845 into master May 21, 2020
@Obsiye Obsiye deleted the bug-allow-temporary-outgoing-type-names branch May 21, 2020 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants