Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGA 2299 Maintenance Message in banner #1145

Merged
merged 4 commits into from
Oct 25, 2022
Merged

LGA 2299 Maintenance Message in banner #1145

merged 4 commits into from
Oct 25, 2022

Conversation

Pheonnexx
Copy link
Contributor

Changed emergency message to take new variables for title and text

What does this pull request do?

Required.

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@Pheonnexx
Added two new variables for message title and text
f1ddd94 
Changed emergency message to take these variables
@Pheonnexx Pheonnexx requested a review from a team as a code owner October 25, 2022 14:36
jogilder
jogilder previously approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jogilder jogilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this as looks ok but am adding a comment here to check that it works - I can see it is deployed to staging with configmap set to true but no message.

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mtac50
Copy link
Contributor

mtac50 commented Oct 25, 2022

Looks great, nice work!
Screenshot 2022-10-25 at 20 19 08

Pheonnexx
Pheonnexx commented Oct 25, 2022
View reviewed changes
Copy link
Contributor Author

@Pheonnexx Pheonnexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

@mtac50 mtac50 requested a review from jogilder October 25, 2022 19:31
@Pheonnexx Pheonnexx merged commit 3c81f6b into master Oct 25, 2022
@Pheonnexx Pheonnexx deleted the feature/LGA-2299-maintenance-banner branch October 25, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtac50 mtac50 mtac50 approved these changes

@jogilder jogilder Awaiting requested review from jogilder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pheonnexx @mtac50 @jogilder