LGA-2267 changing url for BACKEND_BASE_URI to point at backend servic… #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
psweeting1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LGA 2267
What does this pull request do?
Cloud platforms have recommended that we use the backend service namespace to communicate with backend from frontend. So instead of https://fox.civillegaladvice.service.gov.uk/ we should use http://cla-backend-app.laa-cla-backend-production.svc.cluster.local/
Using the service name would mean not using HTTPS but cloud platforms have assured us this is fine as the request will not leave the cluster
Cloudplatform PRs Required before merge:
Production:
production namespace label
Production network policy
Staging:
Staging namespace label
Staging network policy
Any other changes that would benefit highlighting?
All HTTPS calls to fox are not pointing at cla_backend namespace.
Checklist
LGA-2267