LGA-2423 update base images #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow easier updating of packages - going to install pip-compile, this is the first step.
Add in pip-tools to the requirements and set up the pre-commit config
jogilder
force-pushed
the
feature/LGA-2423-update-base-images
branch
2 times, most recently
from
aadac60
to
00d6299
Compare
Update names of files and update pre commit. Have also pinned language version for black to python3.7 as it gave an asyncio error with just python3 Changed name of py-3 job as it is formatting not linting and mirrored set up in cla_backend
testing requirements file was always installed along with base so testing now inherits from base to try and avoid conflicts of packages
jogilder
force-pushed
the
feature/LGA-2423-update-base-images
branch
from
00d6299
to
574bc8e
Compare
jogilder
force-pushed
the
feature/LGA-2423-update-base-images
branch
from
4a2a7e5
to
5c4c453
Compare
Also remove py2-pip package as no longer available from apk add
Separate out the node install into a different stage
jogilder
force-pushed
the
feature/LGA-2423-update-base-images
branch
from
9764b25
to
31e10c2
Compare
Remove unnecessary nginx folder settings and changed uswgi call command
This was mistakenly copied over from cla_backend and is not required
MishNajam
reviewed
May 4, 2023
MishNajam
reviewed
May 4, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
ITHC showed that we were using out of date images for cla_public - this ticket updates the base images and associated packages.
Had to pin black to an exact version - using >= in circleci (as it is in backend) failed one of the files
Any other changes that would benefit highlighting?
Updated requirements files so that they are generated by pip-compile. This will make it easier to update packages in the future.
Changes are based on this test branch created in 2022 and should be checked to make sure I got all of them.
Checklist