Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGA 2451 update email to use notify #1186

Merged
merged 28 commits into from
May 23, 2023
Merged

LGA 2451 update email to use notify #1186

merged 28 commits into from
May 23, 2023

Conversation

jogilder
Copy link
Contributor

@jogilder jogilder commented May 16, 2023 •
edited by TawneeOwl

What does this pull request do?

We are no longer able to use sendgrid so must get cla_public to send emails via gov.notify

Any other changes that would benefit highlighting?

  • Created templates in the Gov UK Notify service to reflect CLA_Public
  • Uploaded secret keys to kubernetes

Checklist

  • [ LGA-2451] (https://dsdmoj.atlassian.net/jira/software/c/projects/LGA/boards/226?modal=detail&selectedIssue=LGA-2451)
  • Import Gov UK Notify into python requirements
  • Created a Gov UK Notify class to send emails in GovUK_Notify/api.py
  • Generated an API Key for Gov UK Notify and assigned this to Helm
  • Amended the views.py file to contain email template logic required to generate individual Gov UK email templates
  • Amended the common.py file to include Gov UK Notify templates and reference the API key
  • Added unit tests for the new Gov UK Notify email system, testing paths for callbacks, third party and confirmation pages

@jogilder jogilder requested a review from a team as a code owner May 16, 2023 09:28
@jogilder jogilder force-pushed the feature/LGA-2451-update-email-to-use-notify branch from 894a483 to 0926042 Compare May 18, 2023 09:17
jogilder and others added 24 commits May 18, 2023 10:31
@jogilder
LGA-2451 create GovNotify object and API key in common.py
c1cfdd8
@jogilder
LGA-2451 amend name of gov notify object to govuk_notify
9da3117
@jogilder
LGA-2451 add govuk_notify as a secret to helm deployment files
a491e5c
@jogilder
LGA-2451 first attempt at sending email using notify not sendgrid
9f9e78f
@jogilder
LGA-2451 templates and thirdparty changes
33eee48 
Use different templates depending on whether a callback number is provided
Add in third party name
@jogilder
LGA-2451 store template ids in common.py
605d864
@jogilder
LGA-2451 update email tests and change how notify object is created
4a03fe3
@jogilder
LGA-2451 update email tests and change how notify object is created
4e0eced
@jogilder
LGA-2451 amended where MagicMock called from
258131e
@jogilder
LGA-2451 refactor how to generate personalisation for emails
907f2d1
@jogilder
LGA-2451 amended tests to work with new refactored code
482c031
@jogilder
LGA-2451 still changing session storage in tests
e1a6d71
@jogilder
LGA-2451 updated unit tests to add thirdparty
a82b4d9
@jogilder
LGA-2451 updated thirdparty logic and removed blank lines
64139b5
@jogilder
LGA-2451 added new template for confirmation page
f15e682
@jogilder
LGA-2451 added new test for confirmation page
18017d6
@TawneeOwl
LGA 2451, updated error handling for Gov Notify service
d2542bb
@TawneeOwl
LGA-2451, updating the name of confirmation no callback to confirmati…
5defa83 
…on page email
@TawneeOwl
WIP 2451, reorganised conditional structure and changed error logging
057ac1a
@TawneeOwl
LGA-2451 Added unit tests for confirmation with callback and restruct…
40d904d 
…ured the views conditions
@TawneeOwl
LGA-2451 Added unit tests for confirmation with callback and restruct…
7fc00d7 
…ured the views conditions
@TawneeOwl
LGA-2451 Updated test_mail scripts to include callback time function,…
641f054 
… changed the reference for callback requested to session stored
@TawneeOwl
LGA-2451 Added test set callback time string test and personalisation…
f2cf343 
… data for tests
@TawneeOwl
LGA-2451 added comments to new functions
aeed453
@TawneeOwl TawneeOwl changed the title WIP LGA 2451 update email to use notify LGA 2451 update email to use notify May 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

said-moj
said-moj approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@said-moj said-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

sarahyjja
sarahyjja approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@sarahyjja sarahyjja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💫

@TawneeOwl TawneeOwl merged commit a181daa into master May 23, 2023
12 of 14 checks passed
@TawneeOwl TawneeOwl deleted the feature/LGA-2451-update-email-to-use-notify branch May 23, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psweeting1 psweeting1 psweeting1 left review comments

@TawneeOwl TawneeOwl TawneeOwl left review comments

@sarahyjja sarahyjja sarahyjja approved these changes

@said-moj said-moj said-moj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jogilder @psweeting1 @sarahyjja @said-moj @TawneeOwl