Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M1 e2e public fixes #1212

Merged
merged 2 commits into from
Sep 20, 2023
Merged

M1 e2e public fixes #1212

merged 2 commits into from
Sep 20, 2023

Conversation

TawneeOwl
Copy link
Contributor

What does this pull request do?

Adds arguments to the dockerfile to allow it to be built different on M1 E2E tests

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@TawneeOwl TawneeOwl requested a review from a team as a code owner September 12, 2023 12:24
BenMillar-CGI
BenMillar-CGI previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@BenMillar-CGI BenMillar-CGI left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's be careful when pushing the changes through and ensure the end-to-end tests work as expected on staging before pushing further 👍

said-moj
said-moj previously approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@said-moj said-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

psweeting1
psweeting1 reviewed Sep 18, 2023
View reviewed changes
docs/installation.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

psweeting1
psweeting1 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pheonnexx
Pheonnexx approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@Pheonnexx Pheonnexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TawneeOwl TawneeOwl merged commit ab9a421 into master Sep 20, 2023
14 checks passed
@TawneeOwl TawneeOwl deleted the m1-e2e-public-fixes branch September 20, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pheonnexx Pheonnexx Pheonnexx approved these changes

@psweeting1 psweeting1 psweeting1 approved these changes

@said-moj said-moj Awaiting requested review from said-moj

@BenMillar-CGI BenMillar-CGI Awaiting requested review from BenMillar-CGI

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TawneeOwl @Pheonnexx @psweeting1 @said-moj @BenMillar-CGI