Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGA-3047: Fixed bug where postcode input disappeared when invalid postcode entered #1254

Merged
merged 2 commits into from
Apr 15, 2024
Merged

LGA-3047: Fixed bug where postcode input disappeared when invalid postcode entered #1254

merged 2 commits into from
Apr 15, 2024

Conversation

BenMillar-CGI
Copy link
Contributor

@BenMillar-CGI BenMillar-CGI commented Apr 15, 2024 •
edited

What does this pull request do?

  • Fixes an issue where the input field was wrongly removed when an invalid postcode was entered.
  • Moves the warning banners to the top of the list.
Screenshot 2024-04-15 at 15 48 26 Screenshot 2024-04-15 at 15 49 06 Screenshot 2024-04-15 at 15 49 53

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@BenMillar-CGI BenMillar-CGI requested a review from a team as a code owner April 15, 2024 12:44
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Pheonnexx
Pheonnexx approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@Pheonnexx Pheonnexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the screenshot

digitalali-moj
digitalali-moj approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@digitalali-moj digitalali-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers!

@BenMillar-CGI BenMillar-CGI merged commit 635bec9 into master Apr 15, 2024
15 checks passed
@BenMillar-CGI BenMillar-CGI deleted the bug/LGA-3047-postcode-input-disapearing-when-invalid-postcode-entered branch April 15, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pheonnexx Pheonnexx Pheonnexx approved these changes

@digitalali-moj digitalali-moj digitalali-moj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BenMillar-CGI @Pheonnexx @digitalali-moj