LGA-1082 quick escape button #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalcolmVonMoJ
force-pushed
the
feature/LGA-1082-flee
branch
from
c240851
to
7d363fe
Compare
said-moj
reviewed
Apr 6, 2020
said-moj
reviewed
Apr 6, 2020
cla_public/templates/base.html
Outdated
|
|
||
| function flee() { | ||
| $("body").hide(); | ||
| {# |
There was a problem hiding this comment.
Do these comments get rendered on the page?
There was a problem hiding this comment.
Can we remove the commented out code then if it's not being used
said-moj
reviewed
Apr 6, 2020
cla_public/templates/base.html
Outdated
| @@ -84,6 +118,36 @@ | |||
|
|
|||
| {% block javascripts %} | |||
| <script> | |||
|
|
|||
| var currentLocation = window.location.href; | |||
| if (currentLocation.indexOf("n43n3") > 0 || currentLocation.indexOf("n43n14/n97") > 0 || currentLocation.indexOf("n88") > 0 || currentLocation.indexOf("n149") > 0 || currentLocation.indexOf("n86") > 0) { | |||
There was a problem hiding this comment.
Is this matching paths in the domestic abuse category? If so you should be able to read the current category with something like session.stored.category (Add the current category as class on the main content wrapper)
There was a problem hiding this comment.
I have used the session.checker.diagnosis_previous_choices check elsewhere on the page for this reason. Is that enough?
Should I use session.stored.category instead of session.checker.diagnosis_previous_choices?
said-moj
reviewed
Apr 6, 2020
{#
The below are all other possibilities but not necessarily the best approach.
var histLength = history.length;
window.history.go(-histLength);
history.pushState({page: 1}, "Cookies", "/cookies")
history.pushState({page: 2}, "Bank Holidays in the UK", "/bank-holidays")
#}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds a quick escape button to the service for certain routes:
Any other changes that would benefit highlighting?
Intentionally left blank.
Checklist