LGA-956 Error Messages

[MalcolmVonMoJ]

What does this pull request do?

• Added specific error messages for each question, removing the format where the question text was repeated with a generic error.
• Rephrased other error messages.
• New error messages for currency rate question types - errors for no value and no frequency, distinct from each other. (New variables for this: freq_message when amount specified but rate (e.g. per week) not answered, and amount_message for the opposite. This has been added to the MoneyIntervalAmountRequired function in validators.py.)
• Stopped error styling from cascading - error message being present still cascades as before.
• Error summary re-positioned at the top of the page - JS change and structure change on many pages - this includes the {{ Form.handle_errors(form) }} being re-positioned on about 10 pages.
• Error summary changed to not use the dl dt dd structure - as per design system.
• Added new JS function (in base.html) for error summary links so they focus on the errorred answer box but only scrolls as far as the relevant question text.
• Changed the error state code so child questions are not in error state if their parent questions are null - affected pop-up questions when their parent was unanswered, errorred, and subsequently answered. (This might have been raised as another bug, but I can't find it now.)
• Added Welsh language for new wording.
• Some smart quote correction and white space tweaks.
• New highlighting for error-state answer boxes.
• Errors re-positioned in relation to the question and hint text (in form.html).

Any other changes that would benefit highlighting?

• Some smart quote correction.

Checklist

• Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

[exonian]

Some excellent stuff here.

One potential missed thing (or otherwise something needs explaining for the likes of me! 😅) and a method which has now become rather complex and hard to read that I'd like us to refactor.

[exonian]

Oh yes, I spotted this when we were writing the signature but planned to lead you towards finding it yourself and then completely forgot 🤦 😅

[exonian]

On reflection, I think this might be worth refactoring to avoid the multiple ifs. Do you fancy pairing on it? Think it could be quite enjoyable.

[exonian]

Very happy with this