Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGA-1218 New welsh translations implemented #969

Merged
merged 4 commits into from
Jul 21, 2020

Conversation

MalcolmVonMoJ
Copy link
Contributor

What does this pull request do?

Added the new Welsh translations to the translation file
Added trans tags around some untranslated text

Any other changes that would benefit highlighting?

Changed some normal quotes to smart quotes

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@MalcolmVonMoJ MalcolmVonMoJ requested a review from a team as a code owner July 10, 2020 16:24
@@ -3349,8 +3400,9 @@ msgid ""
msgstr "Os oes gennych ddyddiad gwrandawiad llys, mae’n bwysig eich bod yn cael cyngor cyn gynted â phosib. Efallai y cewch gymorth ar fyr rybudd ar ddiwrnod y gwrandawiad gan gynghorydd yn adeilad y llys."

#: cla_public/templates/checker/result/confirmation.html:64
# old translation "Beth fydd yn digwydd nesaf?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really...

@@ -3569,8 +3621,9 @@ msgstr "Fel arfer, dim ond os yw’ch plentyn wedi cael anaf i’r ymennydd yn y

#: cla_public/templates/checker/result/face-to-face.html:33
#: cla_public/templates/checker/result/face-to-face.html:58
#old translation: "Beth fydd yn digwydd nesaf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really...

Copy link
Contributor

@mayowaadeniyi mayowaadeniyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MalcolmVonMoJ MalcolmVonMoJ merged commit 74d3d15 into master Jul 21, 2020
@MalcolmVonMoJ MalcolmVonMoJ deleted the feature/LGA-1218-welsh branch July 21, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants