Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGA-1347 Maintenance page #984

Merged
merged 4 commits into from
Aug 18, 2020
Merged

Conversation

said-moj
Copy link
Contributor

@said-moj said-moj commented Aug 12, 2020

What does this pull request do?

  • Adds maintenance mode environment variable
  • Adds a before_request action that when maintenance mode is enabled redirects ALL traffic to the /maintenance page.

Any other changes that would benefit highlighting?

When not in maintenance mode if someone goes to /maintenance then they will be redirected to /start

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@said-moj said-moj requested a review from a team as a code owner August 12, 2020 08:27
@said-moj said-moj force-pushed the feature/LGA-1347-maintenance-page branch from 7176813 to 6aa8fdf Compare August 12, 2020 08:32
@said-moj said-moj changed the title LGA-1347 Maintenance page WIP - LGA-1347 Maintenance page Aug 12, 2020
@exonian
Copy link
Contributor

exonian commented Aug 12, 2020

I'm wondering if there's any merit in trying to redirect back from /maintenance when we're not in maintenance mode. I know it's a bit of a pet peeve of mine to be shunted to one of these pages and know that refreshing won't help any, but it might not be a big enough user issue to actually do.

(I'll look at the code properly after standup)

@said-moj
Copy link
Contributor Author

I'm wondering if there's any merit in trying to redirect back from /maintenance when we're not in maintenance mode. I know it's a bit of a pet peeve of mine to be shunted to one of these pages and know that refreshing won't help any, but it might not be a big enough user issue to actually do.

(I'll look at the code properly after standup)

Wow this is actually a something I haven't considered. Definitely sounds like a bug to me, i'll add.

Good catch

@said-moj said-moj force-pushed the feature/LGA-1347-maintenance-page branch from 16ddce1 to 2381aca Compare August 12, 2020 10:40
@said-moj said-moj changed the title WIP - LGA-1347 Maintenance page LGA-1347 Maintenance page Aug 12, 2020
@said-moj said-moj force-pushed the feature/LGA-1347-maintenance-page branch from 1bf7c8a to 57bd0ba Compare August 14, 2020 09:46
@said-moj said-moj requested a review from exonian August 14, 2020 09:53
@said-moj said-moj merged commit 63ec208 into master Aug 18, 2020
@said-moj said-moj deleted the feature/LGA-1347-maintenance-page branch August 18, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants