Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGA-1342 property prefixes #995

Merged
merged 6 commits into from
Sep 3, 2020
Merged

LGA-1342 property prefixes #995

merged 6 commits into from
Sep 3, 2020

Conversation

MalcolmVonMoJ
Copy link
Contributor

What does this pull request do?

Adds a property prefix so screen readers know that they are dealing with property number 1

  • Sets a variable if property count > 1.
  • Feeds variable into fieldset for all relevant fields.
  • Radio buttons only, the currency fields pick up the fieldset legend.

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@MalcolmVonMoJ MalcolmVonMoJ requested a review from a team as a code owner September 2, 2020 09:35
mayowaadeniyi
mayowaadeniyi approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@mayowaadeniyi mayowaadeniyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MalcolmVonMoJ MalcolmVonMoJ merged commit b1640eb into master Sep 3, 2020
@MalcolmVonMoJ MalcolmVonMoJ deleted the feature/LGA-1342-property branch September 3, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayowaadeniyi mayowaadeniyi mayowaadeniyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MalcolmVonMoJ @mayowaadeniyi