This repository has been archived by the owner on May 13, 2022. It is now read-only.
[WIP] DAPH-180 Fix CustomJsonTest and register all Symfony's error handlers in a new CommonUtils\Sirius\Logging\ErrorHandling class #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vítor Brandão <vitor@noiselabs.io>
vitorbrandao
changed the title
…irius\Logging\ErrorHandling class Signed-off-by: Vítor Brandão <vitor@noiselabs.io>
carnage
reviewed
Sep 14, 2017
Module.php
Outdated
| //global catchall to log when a 400 or 500 error message is set on a response. | ||
| //This is mainly for logging purposes. | ||
| $eventManager->attach( | ||
| MvcEvent::EVENT_FINISH, | ||
| function ($e) use ($logger, $extractor) { | ||
| function ($e) use ($logger, $extractor, $serviceManager) { |
There was a problem hiding this comment.
logger is used; yet you pull from the service manager further down?
…ctions Signed-off-by: Vítor Brandão <vitor@noiselabs.io>
Signed-off-by: Vítor Brandão <vitor@noiselabs.io>
vitorbrandao
changed the title
carnage
reviewed
Sep 18, 2017
| 'category' => 'Event', | ||
| ) | ||
| ); | ||
| $logger->warn('Response: ' . $statusCode . '[' . $e->getResponse() . ']', ['category' => 'Event']); |
There was a problem hiding this comment.
might this log sensitive information?
There was a problem hiding this comment.
It might. However, there are no functional changes introduced in this PR, this is merely a cosmetic change.
composer.json
Outdated
| "zendframework/zendframework": "2.*", | ||
| "psr/log": "^1.0" | ||
| "psr/log": "^1.0", | ||
| "symfony/debug": ">=2.6", |
There was a problem hiding this comment.
can you put an upper bound on this constraint?
| @@ -2,23 +2,10 @@ | |||
|
|
|||
| namespace CommonUtils\Sirius\Logging; | |||
|
|
|||
| use Zend\Db\TableGateway\Exception\RuntimeException; | |||
There was a problem hiding this comment.
If the code was using a RuntimeException could it be pre-fixed with a ?
There was a problem hiding this comment.
RuntimeException isn't being used in this class. Safe to remove.
Signed-off-by: Vítor Brandão <vitor@noiselabs.io>
carnage
approved these changes
Sep 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vítor Brandão vitor@noiselabs.io