Add definition list component for settings screens #1899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new component to make rendering lists for settings screens easier / more consistent.
Instead of this:
we can write this:
Instead of using
with_items
it is also possible to use standard block content within theDefinitionListComponent
and manually renderDefinitionListItemComponent
s e.g.The
DefinitionListItemComponent
also takes adisplay
parameter, giving the ability to hide settings items that are behind feature flags:Questions:
html.erb
template - which is our preference?or a separate html template:
I have opted for the inline method here (mostly for brevity and simplicity) is this the preferred method? Is it easier to understand / reaosn about having it in a more ruby style? Or would we prefer a more 'classic'
html.erb
template?