Send to MS List #2600
Draft
Send to MS List #2600
+1,335
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, configmap and secrets
* Adding route, view and controller for transfer ownership * Adding view for transfer ownership * Adding model for form ownership transfer setting * Adding call to metadata api to get the field created by with form author * Returning the user email rather than the created_by field of the metadata * Adding route and controller to update form owner value * Adding display of error messages * Fix check if email is present in User DB * Refactor validation of user email * Updating version metadata with the new form owner * Content and user design updates * Updating tests for metadata api client to return the field created_by * Adding unit tests for transfer form ownership * Using mock factorybot user present for rspec * Adding modal for confirmation of transfer of ownership Co-authored-by: Chris Pymm <chris.pymm@digital.justice.gov.uk> * Fix brakeman security warning * Adding feature flags --------- Co-authored-by: Chris Pymm <chris.pymm@digital.justice.gov.uk>
StevenLeighton21
force-pushed
the
testable-ms-list-auth
branch
from
3f74ab2
to
6214d7c
Compare
* Add accessibility statement
| @@ -46,4 +46,4 @@ ENV GOVUK_APP_DOMAIN '' | |||
| ENV GOVUK_WEBSITE_ROOT '' | |||
|
|
|||
| ARG RAILS_ENV=production | |||
| CMD bin/delayed_job run | |||
| CMD bin/delayed_job run --queue=testable | |||
There was a problem hiding this comment.
Revert this before merge - used to ensure testable workers pick up the right job
…stable-ms-list-auth
…stable-ms-list-auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.