Limit column descriptions temporarily #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases we have very long descriptions associated with columns. For example: /details/table/urn:li:dataset:(urn:li:dataPlatform:athena,xhibit_derived.all_offence,PROD) Datahub has no restrictions on what we can store here, however our layout has some issues with long text: 1. It is hard to scan through the column list if a single column takes up the whole page 2. If a column description contains a markdown table, we don't render that 3. If we have unparsed markdown with no natural line breaks (such as a column header) then the table grows to encompass its width This workaround allows the page to render properly until these problems are addressed.
This was referenced Apr 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial workaround for #240
A more flexible solution would be to provide a "Show more" button, but I'm going to look at that separately, as I'm not sure how much work it would be to implement.
In some cases we have very long descriptions associated with columns. Datahub has no restrictions on what we can store here, however our layout has some issues with long text:
This workaround allows the problem page to render properly until these problems are addressed.